Re: [PATCH 15/34] frv: handle pgtable_page_ctor() fail

From: Kirill A. Shutemov
Date: Mon Oct 14 2013 - 05:12:43 EST


David Howells wrote:
>
> Acked-by: David Howells <dhowells@xxxxxxxxxx>
>
> for the FRV and MN10300 patches.
>
> Can you move pte_alloc_one() to common code, at least for some arches? I
> think that the FRV and MN10300 ones should end up the same after this - and I
> wouldn't be surprised if some of the other arches do too.

There's no true approach for generic. It depends on what pgtable_t is:
pointer to struct page or virtual address of the allocated page table.
Some arches also use some sort of cache for page table allocator. Others
don't.

I don't see a sensible way generalize it.

--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/