Re: [PATCH] usb/hcd: remove unnecessary local_irq_save

From: Alan Stern
Date: Sun Oct 13 2013 - 11:35:17 EST


On Sun, 13 Oct 2013, Michael Opdenacker wrote:

> Remove the use of local_irq_save() and IRQF_DISABLED, no longer needed since
> interrupt handlers are always run with interrupts disabled on the
> current CPU.
>
> Tested successfully with 3.12.0-rc4 on my PC. Didn't find
> any issue because of this change.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/core/hcd.c | 15 ---------------
> 1 file changed, 15 deletions(-)

How about removing all the other unnecessary usages of IRQF_DISABLED
under drivers/usb while you're at it?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/