Re: [PATCH 25/34] score: handle pgtable_page_ctor() fail

[Lennox Wu]

Thanks.

Acked-by: Lennox Wu <lennox.wu@xxxxxxxxx>

? 2013/10/11 ?? 02:05, Kirill A. Shutemov ??:
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Cc: Chen Liqin <liqin.chen@xxxxxxxxxxxxx>
> Cc: Lennox Wu <lennox.wu@xxxxxxxxx>
> ---
>  arch/score/include/asm/pgalloc.h | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/score/include/asm/pgalloc.h b/arch/score/include/asm/pgalloc.h
> index 059a61b707..2a861ffbd5 100644
> --- a/arch/score/include/asm/pgalloc.h
> +++ b/arch/score/include/asm/pgalloc.h
> @@ -54,9 +54,12 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm,
>  	struct page *pte;
>  
>  	pte = alloc_pages(GFP_KERNEL | __GFP_REPEAT, PTE_ORDER);
> -	if (pte) {
> -		clear_highpage(pte);
> -		pgtable_page_ctor(pte);
> +	if (!pte)
> +		return NULL;
> +	clear_highpage(pte);
> +	if (!pgtable_page_ctor(pte)) {
> +		__free_page(pte);
> +		return NULL;
>  	}
>  	return pte;
>  }

Attachment: signature.asc
Description: OpenPGP digital signature