Re: [PATCH v5 0/4] Fix Win8 backlight issue

From: Yves-Alexis Perez
Date: Sat Oct 12 2013 - 02:00:41 EST


On sam., 2013-10-12 at 00:10 +0200, Rafael J. Wysocki wrote:
> On Friday, October 11, 2013 12:42:43 PM Josh Boyer wrote:
> > On Fri, Oct 11, 2013 at 9:27 AM, Aaron Lu <aaron.lu@xxxxxxxxx> wrote:
> > > v5:
> > > 1 Introduce video.use_native_backlight module parameter and set its
> > > value to false by default as suggested by Rafael. For Win8 systems
> > > which have broken ACPI video backlight control, the parameter can be
> > > set to 1 in kernel cmdline to skip registering ACPI video's backlight
> > > interface. Due to this change, the acpi_video_verify_backlight_support
> > > is moved from video_detect.c to video.c - patch 3/4;
> >
> > That's a fairly untenable position for distro kernels to be in. They
> > now have to ask every user that reports an issue with the backlight to
> > try setting that option on the command line. While I appreciate the
> > setting breaks things for some people, doesn't the Win8 issue impact
> > far more people? Shouldn't it be defaulted to true?
>
> Well, we have a rule in the kernel not to introduce regressions for users even
> if they are minority.

Well, for some users, the regression actually happened when support for
Win8 OSI call was introduced.

Regards,
--
Yves-Alexis

Attachment: signature.asc
Description: This is a digitally signed message part