Re: [PATCH 3/4] VFIO: pci: amend vfio-pci for explicit binding viasysfs only

From: Kim Phillips
Date: Fri Oct 11 2013 - 19:17:28 EST


On Fri, 11 Oct 2013 15:43:40 -0500
Scott Wood <scottwood@xxxxxxxxxxxxx> wrote:

> On Fri, 2013-10-11 at 01:27 -0500, Kim Phillips wrote:
> > Force the vfio-pci driver to only be bound explicitly via sysfs to avoid
> > conflics with other drivers in the event of a hotplug.
> >
> > Signed-off-by: Kim Phillips <kim.phillips@xxxxxxxxxx>
> > ---
> > drivers/vfio/pci/vfio_pci.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> > index 6ab71b9..bdd7833 100644
> > --- a/drivers/vfio/pci/vfio_pci.c
> > +++ b/drivers/vfio/pci/vfio_pci.c
> > @@ -901,6 +901,9 @@ static struct pci_driver vfio_pci_driver = {
> > .probe = vfio_pci_probe,
> > .remove = vfio_pci_remove,
> > .err_handler = &vfio_err_handlers,
> > + .driver = {
> > + .sysfs_bind_only = true,
> > + },
> > };
> >
> > static void __exit vfio_pci_cleanup(void)
>
> You also need to add a PCI_ANY_ID match in order to be able to get rid
> of the new_id usage.

thanks - see below.

Can someone with a PCI bus test this? Bharat?

Kim