RE: [patch x86/hyperv] x86, hyperv: Fix build error

From: KY Srinivasan
Date: Fri Oct 11 2013 - 19:16:30 EST




> -----Original Message-----
> From: David Rientjes [mailto:rientjes@xxxxxxxxxx]
> Sent: Friday, October 11, 2013 4:08 PM
> To: Ingo Molnar; H. Peter Anvin; tglx@xxxxxxxxxxxxx; H. Peter Anvin
> Cc: KY Srinivasan; Olaf Hering; linux-kernel@xxxxxxxxxxxxxxx; linux-tip-
> commits@xxxxxxxxxxxxxxx
> Subject: [patch x86/hyperv] x86, hyperv: Fix build error
>
> 9e7827b5ea4c ("x86, hyperv: Get the local APIC timer frequency from the
> hypervisor") breaks the build with some configs because apic.h isn't
> directly included:
>
> arch/x86/kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform':
> arch/x86/kernel/cpu/mshyperv.c:90:3: error: 'lapic_timer_frequency' undeclared
> (first use in this function)
> arch/x86/kernel/cpu/mshyperv.c:90:3: note: each undeclared identifier is
> reported only once for each function it appears in
>
> Fix it by including asm/apic.h.

Thank you. The issue was configuration related - local APIC was not configured. This has already been fixed.

Regards.

K. Y
>
> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
> ---
> arch/x86/kernel/cpu/mshyperv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -25,6 +25,7 @@
> #include <asm/idle.h>
> #include <asm/irq_regs.h>
> #include <asm/i8259.h>
> +#include <asm/apic.h>
>
> struct ms_hyperv_info ms_hyperv;
> EXPORT_SYMBOL_GPL(ms_hyperv);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/