Re: [PATCH v10 04/12] tracing: Add 'snapshot' event trigger command

[Masami Hiramatsu]

(2013/10/11 9:48), Tom Zanussi wrote:
>  /**
> + * tracing_alloc_snapshot - allocate snapshot buffer.
> + *
> + * This only allocates the snapshot buffer if it isn't already
> + * allocated - it doesn't also take a snapshot.
> + *
> + * This is meant to be used in cases where the snapshot buffer needs
> + * to be set up for events that can't sleep but need to be able to
> + * trigger a snapshot.
> + */
> +int tracing_alloc_snapshot(void)
> +{
> +	struct trace_array *tr = &global_trace;
> +	int ret;
> +
> +	ret = alloc_snapshot(tr);
> +	WARN_ON(ret < 0);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(tracing_alloc_snapshot);

Out of curiously, why this symbol is exported to modules?
The functions which are called directly from trace_event macros
should be exported because those macros can be used in module code,
but I couldn't find this in such code, at a glance.

Thank you,



-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/