Re: [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transferssupport

From: Felipe Balbi
Date: Fri Oct 11 2013 - 09:40:15 EST


Hi,

On Fri, Oct 11, 2013 at 08:23:35AM +0200, Robert Baldyga wrote:
> Hello,
>
> On 10/10/2013 06:04 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Oct 09, 2013 at 08:41:57AM +0200, Robert Baldyga wrote:
> >> @@ -2616,14 +2630,19 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> >> s3c_hsotg_set_ep_maxpacket(hsotg, hs_ep->index, mps);
> >>
> >> /* default, set to non-periodic */
> >> + hs_ep->isochronous = 0;
> >> hs_ep->periodic = 0;
> >> hs_ep->halted = 0;
> >
> > this hunk doesn't apply because of this hs_ep->halted line, which patch
> > does this depend on ?
> >
> it depends on http://www.spinics.net/lists/linux-usb/msg94025.html

I'll fix it up by hand this time, but new features shouldn't (ideally)
directly depend on fixes which you just wrote.

cheers

--
balbi

Attachment: signature.asc
Description: Digital signature