Re: [PATCH] drivers: misc: add gpio wakeup driver

From: Linus Walleij
Date: Fri Oct 11 2013 - 08:54:31 EST


On Fri, Oct 11, 2013 at 1:40 PM, Daniel Mack <zonque@xxxxxxxxx> wrote:

>> Since what the driver will then eventually provide is to
>> flag an IRQ line as wakeup, I wonder if this should not just
>> simply go into the interrupt core, or atleast of/irq.c.
>
> But for that, the IRQ line must be requested exclusively and handled as
> well, no? If not, how would you handle cases where an interrupt is
> marked as wakeup source by the core, but used by another driver which
> calls disable_irq_wake() on it for whatever reason?

Does this driver handle that?

It rather looks like it hogs both the GPIO and IRQ from anyone
else who want it...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/