Re: [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

From: Linus Walleij
Date: Fri Oct 11 2013 - 04:14:39 EST


On Fri, Oct 11, 2013 at 1:48 AM, Sherman Yin <syin@xxxxxxxxxxxx> wrote:

>>> +static const struct capri_cfg_param capri_pinconf_params[] = {
>>> + {"brcm,hysteresis", CAPRI_PINCONF_PARAM_HYST},
>>> + {"brcm,pull", CAPRI_PINCONF_PARAM_PULL},
>>> + {"brcm,slew", CAPRI_PINCONF_PARAM_SLEW},
>>> + {"brcm,input_dis", CAPRI_PINCONF_PARAM_INPUT_DIS},
>>> + {"brcm,drive_str", CAPRI_PINCONF_PARAM_DRV_STR},
>>> + {"brcm,pull_up_str", CAPRI_PINCONF_PARAM_PULL_UP_STR},
>>> + {"brcm,mode", CAPRI_PINCONF_PARAM_MODE},
>>> +};
>>
>>As well as all this stuff...
>
> OK. Will see if I can find something suitable for "input disable" and "mode"

Let's discuss this. What exactly does "input disable" and "mode"
mean, in electrical terms?

When you come down to what actually happens it may turn out that
"input disable" is PIN_CONFIG_OUTPUT, which implicitly turns
off input does it not?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/