Re: [PATCH] UPROBES: Remove useless __weak attribute

[Srikar Dronamraju]

* Ralf Baechle <ralf@xxxxxxxxxxxxxx> [2013-10-09 14:08:09]:

> <linux/uprobes.h> declares arch_uprobe_skip_sstep() as a weak function.
> But as there is no definition of generic version so when trying to build
> uprobes for an architecture that doesn't yet have a arch_uprobe_skip_sstep()
> implementation, the vmlinux will try to call arch_uprobe_skip_sstep()
> somehwere in Stupidhistan leading to a system crash.  We rather want a
> proper link error so remove arch_uprobe_skip_sstep().
> 
> Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> 

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

Will be nice to have another arch(mips) support for uprobes. 

-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/