Re: [rtc-linux] [PATCH V5 2/3] pincntrl: add support for ams AS3722pin control driver

From: Laxman Dewangan
Date: Thu Oct 10 2013 - 05:00:31 EST


On Tuesday 08 October 2013 05:46 PM, Linus Walleij wrote:
On Wed, Oct 2, 2013 at 5:50 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:

The AS3722 is a compact system PMU suitable for mobile phones, tablets etc.

Add a driver to support accessing the GPIO, pinmux and pin configuration
of 8 GPIO pins found on the ams AS3722 through pin control driver and
gpiolib.

The driver will register itself as the pincontrol driver and gpio driver.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
---
Changes from V1:
- Nit cleanups in driver and use module_platform_driver.

Changes from V2:
- Move the gpio driver from gpio folder to pinctnrl driver and register
driver as pincontrol driver.
- Provide pin configuration through pincntrl framework.

Changes from V3:
- Added gpio ranges and pinctrl_gpio calls.
- Used pinctrl_gpio_* calls on gpio chips callback.
- Remove dummy function which just return not supported.
- Nit cleanups.

Changes from V4:
- Drop separate DT binding document as it is moved to mfd/as3722.txt.
As mentioned I am happy with this driver,
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

When you agreed with the DT folks and want me to merge it,
tell me.


Stephen has given the ACK from DT side, so I think you can merge this patch.

Thanks,
Laxman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/