Re: [PATCH 15/52] tools/perf/build: Split out feature check: 'libelf-mmap'

From: Namhyung Kim
Date: Thu Oct 10 2013 - 02:00:30 EST


On Tue, 8 Oct 2013 12:10:45 +0200, Ingo Molnar wrote:
> @@ -202,7 +203,7 @@ ifndef NO_LIBELF
> CFLAGS += -DHAVE_LIBELF_SUPPORT
> FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS)
>
> - ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DHAVE_LIBELF_MMAP_SUPPORT),y)
> + ifeq ($(feature-libelf-mmap), 1)
> CFLAGS += -DHAVE_LIBELF_MMAP_SUPPORT
> endif
>
> @@ -227,8 +228,7 @@ endif # NO_LIBELF
>
> ifndef NO_LIBELF
> CFLAGS += -DHAVE_LIBELF_SUPPORT
> - FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS)
> - ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DHAVE_LIBELF_MMAP_SUPPORT),y)
> + ifeq ($(feature-libelf-mmap), 1)
> CFLAGS += -DHAVE_LIBELF_MMAP_SUPPORT
> endif # try-cc
> endif # NO_LIBELF

As Ulrich Drepper reported, it seems that this hunk is duplicate.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/