Re: [PATCH] perf: disable mmap2 support

[Stephane Eranian]

On Wed, Oct 9, 2013 at 6:24 PM, Stephane Eranian <eranian@xxxxxxxxxx> wrote:
> On Wed, Oct 9, 2013 at 6:21 PM, David Ahern <dsahern@xxxxxxxxx> wrote:
>> On 10/9/13 10:17 AM, Stephane Eranian wrote:
>>>
>>>
>>> This patch disables the mmap2 record format support
>>> for now. The support needs a bit more work to cover
>>> VM_CLONE cases.
>>>
>>> The patch leaves attr->mmap2 defined, but returns
>>> an error if it is set. That ensures no PERF_RECORD_MMAP2
>>> record can be generated. Yet it minimizes the reverts in
>>> the perf tool.
>>
>>
>> The userspace code generates MMAP2 events for synthesized mmap events. That
>> should be reverted to MMAP until the format of MMAP2 events is finalized.
>>
> Ah, yes, that is correct. I forgot about that ;-(
> Let me send a revised patch then that covers both.
>
Looks like the easiest thing to do for perf is to revert:

   Revert "perf tools: Add default handler for mmap2 events"
   git revert 6adb0b0ae26fcc35cfec068d71f13863faac5b44

   Revert "perf tools: Add attr->mmap2 support"
   git revert 5c5e854bc760a2e2c878df3cfcf2afa4febcd511

Do you agree?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/