Re: [PATCH 0/63] Basic scheduler support for automatic NUMAbalancing V9

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> 3)
> 
> Plus in addition to PeterZ's build fix I noticed this new build warning on 
> i386 UP kernels:
> 
>  kernel/sched/fair.c:819:22: warning: 'task_h_load' declared 'static' but never defined [-Wunused-function]
> 
> Introduced here I think:
> 
>     sched/numa: Use a system-wide search to find swap/migration candidates

4)

allyes builds fail on x86 32-bit:

   mm/mmzone.c:101:5: error: redefinition of âpage_cpupid_xchg_lastâ

The reason is the mismatch in definitions:

 mm.h:

  #ifdef LAST_CPUPID_NOT_IN_PAGE_FLAGS

 mmzone.c:

  #if defined(CONFIG_NUMA_BALANCING) && !defined(LAST_CPUPID_IN_PAGE_FLAGS)

Note the missing 'NOT_' in the latter line. I've changed it to:

  #if defined(CONFIG_NUMA_BALANCING) && defined(LAST_CPUPID_NOT_IN_PAGE_FLAGS)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/