Re: [RFC] [PATCH 00/19] Non disruptive application core dump infrastructureusing task_work_add()

[Pavel Emelyanov]

On 10/08/2013 02:12 PM, Janani Venkataraman1 wrote:
> 
> 
> 
> 
> From:	Pavel Emelyanov <xemul@xxxxxxxxxxxxx>
> To:	Janani Venkataraman1/India/IBM@IBMIN,
> Cc:	<linux-kernel@xxxxxxxxxxxxxxx>, <amwang@xxxxxxxxxx>,
>             <rdunlap@xxxxxxxxxxxx>, <andi@xxxxxxxxxxxxxx>,
>             <aravinda@xxxxxxxxxxxxxxxxxx>, <hch@xxxxxx>,
>             <mhiramat@xxxxxxxxxx>, <jeremy.fitzhardinge@xxxxxxxxxx>,
>             <suzuki@xxxxxxxxxxxxxxxxxx>, <kosaki.motohiro@xxxxxxxxxxxxxx>,
>             <adobriyan@xxxxxxxxx>, <tarundsk@xxxxxxxxxxxxxxxxxx>,
>             <vapier@xxxxxxxxxx>, <roland@xxxxxxxxxxxxx>, <tj@xxxxxxxxxx>,
>             <ananth@xxxxxxxxxxxxxxxxxx>, <gorcunov@xxxxxxxxxx>,
>             <avagin@xxxxxxxxxx>, <oleg@xxxxxxxxxx>, <eparis@xxxxxxxxxx>,
>             <d.hatayama@xxxxxxxxxxxxxx>, <james.hogan@xxxxxxxxxx>,
>             <akpm@xxxxxxxxxxxxxxxxxxxx>, <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Date:	10/04/2013 04:08 PM
> Subject:	Re: [RFC] [PATCH 00/19] Non disruptive application core dump
>             infrastructure using task_work_add()
> 
> 
> 
> On 10/04/2013 02:30 PM, Janani Venkataraman wrote:
>> Hi all,
>>
> 
>> This series is based on the Task work add approach. We didn't adopt the
> CRIU
>> approch because of the following reasons:
>>
>> * It is not upstream yet.
> 
> It is, starting from criu-v0.7 + linux-3.11
> 
>> * There are concerns about the security of the dump.
> 
> Can you elaborate on this? Is it fixable in CRIU at all?
> 
>> * It involves a lot of changes and this approach provides a UNIX style
>>   interface.
> 
> Can you also shed more light on this -- what changes do you mean?
> 
> We had a prototype ready earlier using the freezer approach.
> http://lwn.net/Articles/419756/
> 
> We made a couple of minor changes to it and implemented using task work
> add.
> We  wanted to know what the community felt about this approach.
> 
> Also in the previous RFD, Andi Kleen had mentioned a concern on the
> security with
> respect to the daemon approach for a self dump in CRIU.

We have this thing addressed -- when one requests a self-dump from criu daemon
the latter 

a) gets pid to dump from SO_PEERCRED, thus requester cannot just send some other's pid
b) doesn't dump tasks that belong to user other than the one who requested the dump

What other security concerns do you have? We're also interested in addressing them.

> Thanks.
> Janani
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/