Re: [RFC PATCH] device: Add kernel standard devm_k.alloc functions

[Joe Perches]

On Tue, 2013-10-08 at 23:54 -0700, Greg KH wrote:
> On Tue, Oct 08, 2013 at 11:16:44PM -0700, Joe Perches wrote:
> > On Tue, 2013-10-08 at 22:43 -0700, Greg KH wrote:
> > > On Tue, Oct 08, 2013 at 10:32:27PM -0700, Joe Perches wrote:
> > > > Currently, devm_ managed memory only supports kzalloc.
> > > > 
> > > > Convert the devm_kzalloc implementation to devm_kmalloc
> > > > and remove the complete memset to 0 but still set the
> > > > initial struct devres header and whatever padding before
> > > > data to 0.
> > > > 
> > > > Add the other normal alloc variants as static inlines with
> > > > __GFP_ZERO added to the gfp flag where appropriate:
> > > > 
> > > > 	devm_kzalloc
> > > > 	devm_kcalloc
> > > > 	devm_kmalloc_array
> > > > 
> > > > Add gfp.h to device.h for the newly added static inlines.
> > > > 
> > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > > > ---
> > > >  drivers/base/devres.c  | 27 ++++++++++++++++-----------
> > > >  include/linux/device.h | 21 +++++++++++++++++++--
> > > >  2 files changed, 35 insertions(+), 13 deletions(-)
> > > 
> > > Makes sense to me, does this let other drivers start to use this where
> > > they were not able to in the past?
> > 
> > Yes.
> > 
> > There are some existing uses of devm_kzalloc(dev, n*size, gfp)
> > that could/should be converted.
> 
> Ok, great, want me to take the "RFC" off of this and apply it to my
> tree?

Unless Tejun has an objection soon, yes.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/