Re: [PATCH] rtc: rtc-puv3: use dev_dbg() instead of pr_debug()

From: Joe Perches
Date: Wed Oct 09 2013 - 02:20:20 EST


On Wed, 2013-10-09 at 14:49 +0900, Sangjung Woo wrote:
> Because dev_*() are used along with pr_debug() function in this code,
> the debug message is not tidy. This patch converts from pr_debug() to
> dev_dbg() since dev_*() are encouraged to use in device driver code.
[]
> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
[]
> @@ -57,7 +57,7 @@ static void puv3_rtc_setaie(int to)
> {
> unsigned int tmp;
>
> - pr_debug("%s: aie=%d\n", __func__, to);
> + dev_dbg(dev, "%s: aie=%d\n", __func__, to);

Does this compile?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/