Re: [patch 2/3] pvclock: detect watchdog reset at pvclock read

[Marcelo Tosatti]

On Tue, Oct 08, 2013 at 11:58:10AM +0200, Paolo Bonzini wrote:
> Il 08/10/2013 03:05, Marcelo Tosatti ha scritto:
> > +void pvclock_touch_watchdogs(void)
> > +{
> > +	touch_softlockup_watchdog_sync();
> > +	clocksource_touch_watchdog();
> > +	rcu_cpu_stall_reset();
> > +	reset_hung_task_detector();
> > +}
> > +
> 
> Should this function be in kernel/ instead?  It's not really
> pvclock-specific.
> 
> Paolo

kernel/watchdog.c is configurable via CONFIG_LOCKUP_DETECTOR, so its not
appropriate.

And, the choice of watchdogs to reset might be different for the caller.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/