Re: [RFC][PATCH 10/13] make dump_emit() use vfs_write() instead ofbanging at ->f_op->write directly

From: Linus Torvalds
Date: Tue Oct 08 2013 - 21:38:53 EST


On Tue, Oct 8, 2013 at 6:18 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> Point, but I would argue that we should yell very loud if we get 0 from
> vfs_write() for non-zero size. I'm not sure if POSIX allows write(2)
> to return that, but a lot of userland code won't be expecting that and
> won't be able to cope...

Actually POSIX very much allows zero returns. O_NDELAY is mentioned as
a possible cause, in addition to zero-sized writes themselves, of
course.

Also, writing to (but not past) the end of a block device returns 0
for "end of device", iirc.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/