Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the devicetree

[Wolfram Sang]

On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
> If the i2c-parent bus driver is not loaded, returning
> -EINVAL will force people to unload and then reload the
> module again to get it working.
> 
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@xxxxxxx>

Doesn't the non-DT case need fixing, too?

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 5d4a99b..eb99f04 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
>  	adapter = of_find_i2c_adapter_by_node(adapter_np);
>  	if (!adapter) {
>  		dev_err(&pdev->dev, "Cannot find parent bus\n");
> -		return -ENODEV;
> +		return -EPROBE_DEFER;
>  	}
>  	mux->data.parent = i2c_adapter_id(adapter);
>  	put_device(&adapter->dev);
> -- 
> 1.7.1

Attachment: signature.asc
Description: Digital signature