Re: [PATCH 1/5] rcusync: introduce struct rcu_sync_ops

From: Oleg Nesterov
Date: Tue Oct 08 2013 - 11:41:50 EST


On 10/08, Peter Zijlstra wrote:
>
> I think Linus meant to have rcu_sync_{enter,exit} as inlines with a
> const enum argument for the gp_type.
>
> That said; yes that will generate better code, but also more code, and
> like Steven already argued performance isn't really an issue here since
> we're going to potentially sleep for a rather long time.

Yes, I do not think that we should make them "inline". Plus we need the
non-inline rcu_sync_func() anyway.

Thanks again for the last series you sent.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/