Re: [PATCH 2/3] perf stat: Don't require a workload when usingsystem wide or CPU options

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx> wrote:

> Em Mon, Sep 30, 2013 at 07:40:12AM -0600, David Ahern escreveu:
> > On 9/30/13 2:47 AM, Namhyung Kim wrote:
> > >>@@ -1517,8 +1517,10 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused)
> > >>  	} else if (big_num_opt == 0) /* User passed --no-big-num */
> > >>  		big_num = false;
> > >>
> > >>-	if (!argc && !perf_target__has_task(&target))
> > >>+	if (!argc && !perf_target__has_task(&target) &&
> > >>+	    !perf_target__has_cpu(&target))
> > >
> > >You can use perf_target__none() for this.
> > 
> > Indeed. Updated patch attached.
> 
> Cool patch, applying to acme/perf/core.
> 
> While trying it noticed this, that should also be fixed
> eventually:
> 
> [root@zoo ~]# perf stat -c C 0
> C: No such file or directory
> 
>  Performance counter stats for 'C 0':
> 
>      <not counted> task-clock              
>      <not counted> context-switches        
>      <not counted> cpu-migrations 
> <SNIP>

Btw., would anyone be interested in adding CPU and node binding options to 
perf stat?

There's code to do something like that in tools/perf/bench/numa.c:

        /* Special option string parsing callbacks: */
        OPT_CALLBACK('C', "cpus", NULL, "cpu[,cpu2,...cpuN]",
                        "bind the first N tasks to these specific cpus (the rest is unbound)",
                        parse_cpus_opt),
        OPT_CALLBACK('M', "memnodes", NULL, "node[,node2,...nodeN]",
                        "bind the first N tasks to these specific memory nodes (the rest is unbound)",
                        parse_nodes_opt),

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/