Re: [PATCH 00/16] sched/wait: Collapse __wait_event macros -v5

From: Ingo Molnar
Date: Tue Oct 08 2013 - 06:23:42 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Sat, Oct 05, 2013 at 10:04:16AM +0200, Ingo Molnar wrote:
> >
> > * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> >
> > > On Fri, Oct 04, 2013 at 10:44:05PM +0200, Peter Zijlstra wrote:
> > > >
> > > > slightly related; do we want to do something like the following two
> > > > patches?
> > >
> > > and
> >
> > Yeah, both look good to me - but I'd move them into
> > kernel/sched/completion.c and kernel/sched/wait.c if no-one objects.
>
> Do you also want to suck in semaphore.c mutex.c rwsem.c spinlock.c etc?
> Or do you want to create something like kernel/locking/ for all that.

Yeah, I think kernel/locking/ would be a suitable place for those, and I'd
move lockdep*.c there too. (Such things are best done near the end of a
merge window, when there's not much pending, to not disrupt development.)

kernel/*.c is a pretty crowded place with 100+ files currently, I've been
gradually working towards depopulating it slowly but surely for subsystems
that I co-maintain or where I'm frequently active. We already have:

kernel/sched/
kernel/events/
kernel/irq/
kernel/time/
kernel/trace/

and the deeper kernel/*/* hierarchies already host another ~100 .c files.
So the transition is half done already I suspect.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/