Re: [PATCH] pinctrl: pinctrl-adi2: GPIO output value should be setafter the GPIO interrupt is disabled.

[Sonic Zhang]

Hi Axel,

On Tue, Oct 8, 2013 at 3:48 PM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
> 2013/10/8 Sonic Zhang <sonic.adi@xxxxxxxxx>:
>> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
>>
>> Use BIT macro as well.
>>
>> Signed-off-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
>> ---
>>  drivers/pinctrl/pinctrl-adi2.c | 14 ++++++++------
>>  1 file changed, 8 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c
>> index a74e6f4..7a39562 100644
>> --- a/drivers/pinctrl/pinctrl-adi2.c
>> +++ b/drivers/pinctrl/pinctrl-adi2.c
>> @@ -766,9 +766,9 @@ static void adi_gpio_set_value(struct gpio_chip *chip, unsigned offset,
>>         spin_lock_irqsave(&port->lock, flags);
>>
>>         if (value)
>> -               writew(1 << offset, &regs->data_set);
>> +               writew(BIT(offset), &regs->data_set);
>>         else
>> -               writew(1 << offset, &regs->data_clear);
>> +               writew(BIT(offset), &regs->data_clear);
>>
>>         spin_unlock_irqrestore(&port->lock, flags);
>>  }
>> @@ -780,12 +780,14 @@ static int adi_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
>>         struct gpio_port_t *regs = port->regs;
>>         unsigned long flags;
>>
>> -       adi_gpio_set_value(chip, offset, value);
>> -
>>         spin_lock_irqsave(&port->lock, flags);
>>
>> -       writew(readw(&regs->inen) & ~(1 << offset), &regs->inen);
>> -       writew(1 << offset, &regs->dir_set);
>> +       writew(readw(&regs->inen) & ~BIT(offset), &regs->inen);
>> +       if (value)
>> +               writew(BIT(offset), &regs->data_set);
>> +       else
>> +               writew(BIT(offset), &regs->data_clear);
>
> I think we can add an unlocked version of adi_gpio_set_value() to
> avoid duplicated code.

That may be over engineering for such a simple code.

Regards,

Sonic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/