Re: [PATCH 03/27] mmc: bfin_sdh: Move away from using deprecated APIs

From: Sonic Zhang
Date: Mon Oct 07 2013 - 23:05:47 EST


Acked-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx>

On Thu, Sep 26, 2013 at 10:54 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> Suspend and resume of cards are being handled from the protocol layer
> and consequently the mmc_suspend|resume_host APIs are deprecated.
>
> This means we can simplify the suspend|resume callbacks by removing the
> use of the deprecated APIs.
>
> Cc: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
> Cc: uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> ---
> drivers/mmc/host/bfin_sdh.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c
> index 94fae2f..bc9110f 100644
> --- a/drivers/mmc/host/bfin_sdh.c
> +++ b/drivers/mmc/host/bfin_sdh.c
> @@ -640,21 +640,15 @@ static int sdh_remove(struct platform_device *pdev)
> #ifdef CONFIG_PM
> static int sdh_suspend(struct platform_device *dev, pm_message_t state)
> {
> - struct mmc_host *mmc = platform_get_drvdata(dev);
> struct bfin_sd_host *drv_data = get_sdh_data(dev);
> - int ret = 0;
> -
> - if (mmc)
> - ret = mmc_suspend_host(mmc);
>
> peripheral_free_list(drv_data->pin_req);
>
> - return ret;
> + return 0;
> }
>
> static int sdh_resume(struct platform_device *dev)
> {
> - struct mmc_host *mmc = platform_get_drvdata(dev);
> struct bfin_sd_host *drv_data = get_sdh_data(dev);
> int ret = 0;
>
> @@ -665,10 +659,6 @@ static int sdh_resume(struct platform_device *dev)
> }
>
> sdh_reset();
> -
> - if (mmc)
> - ret = mmc_resume_host(mmc);
> -
> return ret;
> }
> #else
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/