Re: Preferred line-break style around binary operators?

From: Joe Perches
Date: Sun Oct 06 2013 - 18:01:54 EST


On Sun, 2013-10-06 at 14:48 -0700, Josh Triplett wrote:
> There are two common approaches to breaking long lines at binary
> operators: breaking the line before the operator (putting the operator
> at the start of the next line), or breaking the line after the operator
> (putting the operator at the end of the previous line).
>
> CodingStyle doesn't define any requirement here, and the kernel uses
> both approaches; for instance, using && as a sample:
>
> $ git grep -h '&&$' | wc -l
> 28872
> $ git grep -h '^[[:space:]]*&&' | wc -l
> 4169
>
> Which style should kernel code use? I can submit a CodingStyle patch
> documenting that preference for future reference.

That was pretty contentious awhile ago.
An example:
https://lkml.org/lkml/2009/12/5/30

net/ and drivers/net/ use && and || at EOL.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/