Re: [PATCH 1/2] regulator: wm8994: Remove redundant break

From: Mark Brown
Date: Fri Oct 04 2013 - 06:47:29 EST


On Fri, Oct 04, 2013 at 03:18:17PM +0530, Sachin Kamat wrote:

> default:
> return (selector * 100000) + 950000;
> }
> - break;
> default:

I'm not sure this is actually a clarity improvement. While the break is
redundant the return statements are all inside the nested switch so it's
not entirely obvious at a glance that all the paths were covered.

Attachment: signature.asc
Description: Digital signature