[PATCH] regulator: palmas: get regulators node from parent node only

From: Laxman Dewangan
Date: Thu Oct 03 2013 - 09:42:52 EST


The device tree binding of Palmas regulator driver says as:

palmas_pmis {
compatible = "ti,palmas-pmic";
...
regulators {
...
}
};

In this "regulators" subnode is expected to be part of parent node, not
the outside of parent node. Hence to get the regulator node, the correct
call is of_get_child_by_name() rather than of_find_node_by_name() which
actually searches the "regulators" node from the parent node to end of DTS
file.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
---
The same issue exist on other drivers like tps65910, ts6586x, tps65090.
I will post the patches once this is fine.

drivers/regulator/palmas-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 9d87c30..9c62b1d 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -820,7 +820,7 @@ static void palmas_dt_to_pdata(struct device *dev,
int idx, ret;

node = of_node_get(node);
- regulators = of_find_node_by_name(node, "regulators");
+ regulators = of_get_child_by_name(node, "regulators");
if (!regulators) {
dev_info(dev, "regulator node not found\n");
return;
--
1.7.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/