Re: [PATCH RFC 34/77] ioat: Update MSI/MSI-X interrupts enablement code

From: Williams, Dan J
Date: Wed Oct 02 2013 - 14:00:58 EST


On Wed, Oct 2, 2013 at 10:31 AM, Williams, Dan J
<dan.j.williams@xxxxxxxxx> wrote:
> [ dropping all cc's except lkml ]
>
> On Wed, Oct 2, 2013 at 3:48 AM, Alexander Gordeev <agordeev@xxxxxxxxxx> wrote:
>> As result of recent re-design of the MSI/MSI-X interrupts enabling
>> pattern this driver has to be updated to use the new technique to
>> obtain a optimal number of MSI/MSI-X interrupts required.
>>
>
> What happens if this patch is not applied. This changelog does not
> have enough information for me to judge the patch. Unless I missed it
> I do not see a patch 00/77 explaining the background of the change,
> and a quick search did not turn up a discussion of why drivers now
> need to call pci_msix_table_size() prior to pci_enable_msix.

I see patch 00/77 now and I still don't see the need for ioatdma to be
updated. If we fail the subsequent request_irq, the driver will still
fall back to trying less interrupts.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/