Re: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQhandler

From: Kim Phillips
Date: Wed Oct 02 2013 - 12:44:10 EST


On Wed, 2 Oct 2013 14:08:44 +0300
Taras Kondratiuk <taras.kondratiuk@xxxxxxxxxx> wrote:

> From: Danke Xie <d.xie@xxxxxxxxxxxxxxx>
>
> The current TWL 6030 IRQ handler assumes little endianness.
> This change makes it endian-neutral.
>
> Signed-off-by: Danke Xie <d.xie@xxxxxxxxxxxxxxx>
> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@xxxxxxxxxx>
> ---

this patch causes a new sparse warning:

make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o
...
CHECK drivers/mfd/twl6030-irq.c
drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32

does int_sts in the sts union need to be defined as __le32?

Thanks,

Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/