Re: [PATCH v2] Staging : android: binder.c: Prefer seq_puts toseq_printf

From: Joe Perches
Date: Wed Oct 02 2013 - 00:06:29 EST


On Tue, 2013-10-01 at 23:57 -0400, Mathieu Rhéaume wrote:
> Changes since v2:
> * Fixed the indent problems (2 tab and 1 space) by Joe Perches.
> * Found more calls to convert from seq_printf to seq_puts
[]
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -3272,33 +3272,33 @@ binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer)
> static void print_binder_transaction(struct seq_file *m, const char *prefix,
> struct binder_transaction *t)
> {
> - seq_printf(m,
> - "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",
> - prefix, t->debug_id, t,
> - t->from ? t->from->proc->pid : 0,
> - t->from ? t->from->pid : 0,
> - t->to_proc ? t->to_proc->pid : 0,
> - t->to_thread ? t->to_thread->pid : 0,
> - t->code, t->flags, t->priority, t->need_reply);
> + seq_puts(m, "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",

Only indent the subsequent lines
not the initial seq_puts.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/