Re: perf, x86: Add last TSX PMU code for Haswell v2

From: Jiri Olsa
Date: Mon Sep 30 2013 - 16:27:34 EST


On Mon, Sep 30, 2013 at 10:17:21PM +0200, Jiri Olsa wrote:
> On Fri, Sep 20, 2013 at 07:40:38AM -0700, Andi Kleen wrote:
> > [This has kernel and user parts, so will need
> > review/ack/merges from both perf kernel and user land maintainers]
> > [v2: Address Peter's feedback for the kernel parts]
> >
> > This is currently the last part of the TSX PMU code,
> > just adding the left over bits:
> >
> > This adds some changes to the user interfaces.
> > I'll send patches for the manpage separately.
> >
> > - Report the transaction abort flags to user space
> > using a new field, and add the code to display them.
> > This is used to classify abort types, also fairly
> > important for tuning as it guides the tuning process,
> > together with the abort weight that was added earleir.
> >
> > [3 patches, generic, x86, user tools]
> >
> > - Add support for reporting the two new TSX LBR flags: in_tx
> > and abort_tx. The code to handle the LBRs was already
> > added earlier, this just adds the code to report,
> > filter and display them.
>
> perf tool changes look ok
>
> Reviewed-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>
> btw, kernel changes didn't apply cleanly on tip tree for me
> last week.. I couldn't test on Haswel, but I at least tried
> your changes with no data and all seem ok ;-)

I knew I've already sent this out! heh, even acked ;-)
http://marc.info/?l=linux-kernel&m=138021331913851&w=2

got confused by your new PING^2

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/