Re: [PATCH] perf auto-dep: Speed up feature tests by building themin parallel

From: Ingo Molnar
Date: Mon Sep 30 2013 - 15:04:44 EST



* Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx> wrote:

> Em Mon, Sep 30, 2013 at 10:34:27AM -0700, Linus Torvalds escreveu:
> > On Mon, Sep 30, 2013 at 10:12 AM, Arnaldo Carvalho de Melo
> > <acme@xxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > Checking why that strlcpy failed...
> >
> > I don't think glibc does strlcpy. It's not a standard C function, and
>
> My concern was more about the thinking: ``Is this red "OFF" thing a
> problem? I feel so much more confortable when all entries have nice
> green "on" lights...''

Yeah, so I think we should add our internal implementation of strlcpy() as
a __weak function instead - if the libc does not provide then we provide a
fallback.

That should get rid of another ~50 msecs of build overhead, as failed
feature tests are the most expensive ones.

Agreed?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/