Re: [PATCHv6 02/16] drivers: thermal: introduce device tree parser

[Mark Rutland]

On Tue, Sep 24, 2013 at 10:33:19PM +0100, Eduardo Valentin wrote:
> On 23-09-2013 06:40, Mark Rutland wrote:
> > 
> > It would be nice to have a name for the cells after a phandle which
> > describe the cooling device's configuration. You've called them
> > parameters here, but it probably makes sense to call them a
> > cooling-specifier (following clock-specifier and interrupt-specifier).
> 
> Maybe it was not very clear, and I am working on improving this, but
> what I am proposing is simply to have:
>  cooling-device = <&cdev min max>
> 
> where min and max are one cell unsigned values referring to minimum
> cooling level and maximum cooling level, for this reference. Note that
> 'cdev' may have 10 levels, but in this reference we may use only from 6
> to 10:
>  cooling-device = <&cdev 6 10>;
> 
> I don't see a need to have a cooling-names for this case. And for now, I
> also don't see why we would use other specifiers. But we can leave it
> open for future extensions.

There seesm to be some confusion ehre, so let me clarify.  I was asking
for consistent terminology (i.e. "cooling-specifier" rather than
"parameters"), not *-names properties. Consistent terminology and style
makes binding far easier to read.

> 
> It does make sense to have thermal-sensor-names (using thermal-sensor as
> per your suggestion). Because it makes clear where the sensor is in the
> case of using several sensors in one zone. Just like in the example I
> already gave:

Is there a way this can be useful at run-time, or could this just be
achieved with comments in the dt?

> > +cpu-thermal: cpu-thermal {
> > +	polling-delay-passive = <250>; /* milliseconds */
> > +	polling-delay = <1000>; /* milliseconds */
> > +
> > +		/* sensor       ID */
> > +     thermal-sensors = <&bandgap0	0>,
> > +		  	  <&adc		0>;
> > +	thermal-sensors-names = "cpu", "pcb north";
> > +
> > +		/* hotspot = 100 * bandgap - 120 * adc + 484 */
> > +	coefficients = 		<100	-120	484>;
> > +
> > +        trips {
> > +		...
> > +        };
> > +
> > +	cooling-attachments {
> > +		...
> > +	};
> > +};

Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/