Re: [PATCH 1/1] fs/binfmt_elf.c: fill_note_info: Reduce scope of a variable

From: Geyslan GregÃrio Bem
Date: Sat Sep 28 2013 - 19:42:31 EST


Please, disconsider this e-mail.

Geyslan GregÃrio Bem
hackingbits.com


2013/9/28 Geyslan G. Bem <geyslan@xxxxxxxxx>:
> The *t variable in the fill_note_info function is only used if
> siginfo->si_signo isn't 0. Moving "t" pointer to that inner scope.
>
> Tested.
>
> Signed-off-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
> ---
> fs/binfmt_elf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
> index 100edcc..d0ac15b 100644
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -1848,12 +1848,11 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
> struct elf_note_info *info,
> siginfo_t *siginfo, struct pt_regs *regs)
> {
> - struct list_head *t;
> -
> if (!elf_note_info_init(info))
> return 0;
>
> if (siginfo->si_signo) {
> + struct list_head *t;
> struct core_thread *ct;
> struct elf_thread_status *ets;
>
> --
> 1.8.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/