Re: [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform_driver'

[richard -rw- weinberger]

On Sat, Sep 28, 2013 at 8:14 PM,  <elad.wexler@xxxxxxxxx> wrote:
> From: Elad Wexler <elad.wexler@xxxxxxxxx>
>
> Driver doesn't do anything special in 'module_init'.
>
> 'module_platform_init' makes the code more readable.
>
> Signed-off-by: Elad Wexler <elad.wexler@xxxxxxxxx>

NAK.

By moving to module_platform_init() you make this module unloadable.
Currently it is unloadable for good reasons.
The cs5535-mfgpt chip is nasty because it has no reliable reset function.
Therefore by unloading and loading the module again bad things can happen.

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/