Re: [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu ops

[Ingo Molnar]

* Christoph Lameter <cl@xxxxxxxxx> wrote:

> > The blind __this_cpu conversions without proper preempt debugging 
> > cannot continue without first fixing all the fallout of the missing 
> > debug checks to begin with.
> 
> That will take some time as the feedback from the other patchset 
> suggests.

That's the reason why we insisted on __this_cpu*() primitives growing 
these essential debug checks early on - which you resisted. I had to bring 
out NAKs for you to see sense and start fixing the mess already - next 
time around I'll probably have to NAK your changes earlier to prevent such 
mishaps.

( Note that some false positives were possibly fixed by the use of the 
  lib/smp_processor_id.c methods to check for preemptability, so the 
  situation might not be as dire as your first series suggests. )

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/