Re: [PATCH 1/3] spi: Add a spi_w8r16be() helper

From: Mark Brown
Date: Fri Sep 27 2013 - 14:35:42 EST

On Fri, Sep 27, 2013 at 04:34:27PM +0200, Lars-Peter Clausen wrote:
> This patch adds a new spi_w8r16be() helper, which is similar to spi_w8r16()
> except that it converts the read data word from big endian to native endianness
> before returning it. The reason for introducing this new helper is that for SPI

This actually feels like a bug in spi_w8r16() - I'd expect it to be
returning native endian in the first place since in SPI a word is by
default big endian so I'd expect this to have more of a register I/O
model. It certainly seems to match what almost all of the users are

That said I'm not sure this is worth fixing in which case the new API
makes sense. Or converting the users to regmap I guess.

Attachment: signature.asc
Description: Digital signature