Re: [PATCH 1/2] gpio/omap: maintain GPIO and IRQ usage separately
From: Kevin Hilman
Date: Fri Sep 27 2013 - 14:08:54 EST
Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> writes:
> The GPIO OMAP controller pins can be used as IRQ and GPIO
> independently so is necessary to keep track GPIO pins and
> IRQ lines usage separately to make sure that the bank will
> always be enabled while being used.
>
> Also move gpio_is_input() definition in preparation for the
> next patch that setups the controller's irq_chip driver when
> a caller requests an interrupt line.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
I'm fine with this appproach. For both patches:
Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxx>
Also, I gave it a spin across a handful of OMAP boards using v3.12-rc2 +
these 2 patches.
Boot tested successfully with DT boot:
omap3530/beagle
omap3730/beagle-xm
omap3530/overo (Tobi w/GPIO IRQ networking)
omap3730/overo STORM (w/GPIO IRQ for networking)
am335x/beaglebone
am335x/beaglebone black
omap4430/panda
omap4460/panda-es
omap5912/OSK (omap1)
I also verified non-DT boot on the OMAP3 platforms that still support
legacy boot.
So feel free to also add
Tested-by: Kevin Hilman <khilman@xxxxxxxxxx>
Thanks for your persistence in getting a fix for this upstream.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/