Re: [PATCH 1/2] pinctrl: palmas: do not abort pin configuration forBIAS_DEFAULT

From: Laxman Dewangan
Date: Fri Sep 27 2013 - 09:07:40 EST

On Thursday 26 September 2013 09:08 PM, Stephen Warren wrote:
On 09/26/2013 06:48 AM, Laxman Dewangan wrote:
Recent movement of all configurations of pin in the single call of
pin_config_set(), it is aborting configuration if BIAS_PULL_PIN_DEFAULT
is selected as return of configuration.

The original idea was to just avoid any update on register for pull up/down
configuration if this option is selected.
That doesn't sound correct. If a config option is specified in DT or the
mapping table, it should be applied to HW. If someone doesn't want a
particular config option applied, then it simply shouldn't be mentioned
in DT or the mapping table.

IIUC, BIAS_DEFAULT should be used only on HW where there is a concept of
a true default bias, and in that case, that is what should be applied.

Hmm.. When I added the PIN_DEFAULT, I just though that do not update anything in the register and implemented like that.
There is nothing "default" option in HW.

In this patch, I just fixed the broken stuff due to recent change.

However, it the PIN_DEFAULT is not valid option then I need to remove it from driver as well as from dt document of Palmas.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at