Re: [PATCH v6 5/6] MCS Lock: Restructure the MCS lock defines andlocking code into its own file

From: Peter Zijlstra
Date: Fri Sep 27 2013 - 07:24:07 EST

On Fri, Sep 27, 2013 at 08:02:13AM +0200, Ingo Molnar wrote:
> Would be nice to have this as a separate, add-on patch. Every single
> instruction removal that has no downside is an upside!
> You can add a comment that explains it.

If someone is going to do add-on patches to the mcslock.h file, please
also consider doing a patch that adds comments to the memory barriers in

Also, should really warn about that; and it appears there
code in there for that; however:

# grep -C3 smp_mb scripts/
# check for memory barriers without a comment.
if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
if (!ctx_has_comment($first_line, $linenr)) {
"memory barrier without comment\n" . $herecurr);
# grep -C3 smp_wmb kernel/mutex.c
ACCESS_ONCE(prev->next) = node;
/* Wait until the lock holder passes the lock down */
while (!ACCESS_ONCE(node->locked))
ACCESS_ONCE(next->locked) = 1;

# scripts/ -f kernel/mutex.c 2>&1 | grep memory

so that appears to be completely broken :/

Joe, any clue what's up with that?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at