Re: [PATCHSET] sysfs: implement sysfs_remove()

From: Greg KH
Date: Thu Sep 26 2013 - 19:44:38 EST

On Thu, Sep 19, 2013 at 12:03:08PM -0500, Eric W. Biederman wrote:
> I am running from memory right now. But the short version is.
> Al Viro has complained about the sysfs removal antics of sysfs, and
> I have seen Al get confused and "fix" filesystems that depart too far
> from normal filesystem semantics.
> I have gone down this path both ways and "rm -rf" semantics are horrible
> and cause real bugs in the kernel at the boundaries between devices.
> "rm -rf" semantics are also horrible because no sanity checks can be
> performed.

I seem to remember some issues here as well, probably with scsi devices,
that kept us from doing this in this manner. Can you test this on
removing some scsi devices and see if everything still works properly
with this patchset applied?

I'm really hesitant to apply this series, as it does change how sysfs
works in this area, why do you need these changes?

> I will aim to take a second look when I can spend a little more time
> and give you more concrete reasons (other than the old NAK from Viro)
> about why recursive sysfs directory removal can cause real bugs. It is
> just subtle enough I can't remember the set of the problems in detail
> and a quick look at the code is not enough to remind me. But I have run
> into real issues with even the limited recursive remvoval that sysfs
> does today.

What real issues did you run into?


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at