Re: [PATCH V2 05/18] regulator: fixed: use devm_regulator_register()

From: Mark Brown
Date: Thu Sep 26 2013 - 06:16:14 EST


On Thu, Sep 26, 2013 at 03:25:59PM +0900, Jingoo Han wrote:
> On Thursday, September 26, 2013 3:14 PM, Sachin Kamat wrote:

> > > - regulator_unregister(drvdata->dev);
> > > kfree(drvdata->desc.supply_name);
> > > kfree(drvdata->desc.name);

> > Sorry, couldn't go through all your patches yesterday.
> > This one looks a bit scary too as some of the driver data is already
> > freed before unregistering.

> I looked at regulator_unregister(). I am not sure that this is safe.
> So, I will remove this patch from next v3 patch series.
> Thank you for your comment. :-)

Yes, it'd be better to convert the allocations to be managed ones first.

Attachment: signature.asc
Description: Digital signature