Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD

From: Felipe Balbi
Date: Wed Sep 25 2013 - 16:34:35 EST


Hi,

On Wed, Sep 25, 2013 at 10:17:38AM +0200, Pali Rohár wrote:
> On Wednesday 18 September 2013 19:03:33 Pali Rohár wrote:
> > &twl->phy.notifier is not initalized
> >
> > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx>
> >
> > diff --git a/drivers/usb/phy/phy-twl4030-usb.c
> > b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155
> > 100644
> > --- a/drivers/usb/phy/phy-twl4030-usb.c
> > +++ b/drivers/usb/phy/phy-twl4030-usb.c
> > @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct
> > platform_device *pdev) if (device_create_file(&pdev->dev,
> > &dev_attr_vbus)) dev_warn(&pdev->dev, "could not create sysfs
> > file\n");
> >
> > + ATOMIC_INIT_NOTIFIER_HEAD(&twl->phy.notifier);
> > +
> > /* Our job is to use irqs and status from the power module
> > * to keep the transceiver disabled when nothing's
> > connected. *
>
> I sent above patch week ago. Did you already included it?

look at my testing branch.

--
balbi

Attachment: signature.asc
Description: Digital signature