Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7790: add pin definitions forthe I2C3 interface

From: Simon Horman
Date: Wed Sep 25 2013 - 00:52:05 EST


On Mon, Sep 23, 2013 at 10:50:07AM +0200, Linus Walleij wrote:
> On Tue, Sep 17, 2013 at 7:10 PM, Guennadi Liakhovetski
> <g.liakhovetski@xxxxxx> wrote:
> > On Tue, 17 Sep 2013, Linus Walleij wrote:
>
> >> > +/* R8A7790 has 6 banks with 32 GPIOs in each = 192 GPIOs */
> >> > +#define ROW_GROUP_A(r) ('Z' - 'A' + 1 + (r))
> >> > +#define PIN_NUMBER(r, c) (((r) - 'A') * 16 + (c) + 200)
> >> > +#define PIN_A_NUMBER(r, c) PIN_NUMBER(ROW_GROUP_A(r), c)
> >>
> >> You add these #defines but do not use them.
> >
> > ehm, actually I do:
>
> Argh I was just wrong, forget about this.
>
> Woudl really like Laurent's ACK on this before I apply it though.

Laurent, ping.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/