Re: [patch] mm, mempolicy: make mpol_to_str robust and always succeed

From: Dave Jones
Date: Tue Sep 24 2013 - 23:11:49 EST


On Tue, Sep 24, 2013 at 07:58:22PM -0700, David Rientjes wrote:

> case MPOL_BIND:
> - /* Fall through */
> case MPOL_INTERLEAVE:
> nodes = pol->v.nodes;
> break;

Any reason not to leave this ?

"missing break" is the 2nd most common thing that coverity picks up.
Most of them are false positives like the above, but the lack of annotations
in our source makes it time-consuming to pick through them all to find the
real bugs.

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/