Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

[Arnaldo Carvalho de Melo]

Em Tue, Sep 24, 2013 at 05:09:21PM +0900, Namhyung Kim escreveu:
> On Mon, 23 Sep 2013 11:26:59 +0200, Borislav Petkov wrote:
> > On Mon, Sep 23, 2013 at 06:15:09PM +0900, Namhyung Kim wrote:
> >> I replaced them to a single -w option since all we want to do is
> >> suppress any warning, right?

> > Do we? And besides, -w is a big hammer as it shuts up all warnings.
> > acme?

> > I think special handling those files grew out of necessity to shut up
> > some warnings but acme would know better.

Yes, there were reasons for disabling some warnings on some files, would
have to look at the git history to see...

commit 09c0211c0bb0e40231e6ee9a35041d467ed72f16
Author: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date:   Fri May 4 11:32:54 2012 -0700

    perf: Turn off compiler warnings for flex and bison generated files
    
    We don't know what types of warnings different versions of flex
    and bison combined with different versions of gcc is going to
    generate, so just punt and don't warn about anything.
    
    This fixes the build of perf for me on an openSUSE 12.1 system.


commit 575bf1d04e908469d26da424b52fc1b12a1db9d8
Author: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
Date:   Mon Jun 24 11:43:14 2013 +0300

    perf tools: Fix build with perl 5.18
    
    perl.h from new Perl release doesn't like -Wundef and -Wswitch-default:

etc.

 
> I don't know.  I just thought there's not much thing we can do for those
> files other than shutting up all warnings.
 
> But if you think that's not the right thing, I'll keep the existing
> options.  What do you think, Arnaldo?

I think keeping the existing options is the right thing to do, if some
of that can be simplified or made like you did it in your patch, then
that is the matter for a separate patch, with proper explanation.
 
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/