Re: [PATCH 0/22] Immutable biovecs, block layer changes

From: Mike Snitzer
Date: Tue Sep 24 2013 - 09:20:49 EST


On Tue, Sep 24 2013 at 7:00am -0400,
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> Just curious, what's the state of the remaining immutable bio work?

Hey Christoph,

Have you been over the patchset? Looks sane to you?

Given how disruptive this patchset is to the block layer I'm wondering
how painful this change will be in combination with Jens' blk-mq
changes. I'd prefer to see blk-mq before immutable biovecs; but I have
my own selfish reasons for that.

I'm also concerned about DM regressions given that a lot of DM code to
handle splitting a bio that spans target boundaries is ripped out, see:
https://patchwork.kernel.org/patch/2840657/

But that is just handwaving/FUD at this point cause I haven't put the
time to looking at this patchset close enough to feel comfortable. I
can make reviewing this patchset a priority this week though.

Kent, have you rebased this patchset at all? Do you have a git tree I
can clone to save the pain of pulling these patches out my my mbox,
etc.

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/