Re: scripts/config: fix variable substitution command

[Sedat Dilek]

On Sat, Sep 14, 2013 at 4:21 PM, ClÃment Chauplannaz <chauplac@xxxxxxxxx> wrote:
> 2013/9/14 Sedat Dilek <sedat.dilek@xxxxxxxxx>:
>> Hi,
>>
>> The ChangeLog from [1] says:
>>
>> Commit 229455bc02b87f7128f190c4491b4ceffff38648 accidentally changed
>> the separator between sed `s' command and its parameters from ':' to
>> '/'.
>> Revert this change.
>>
>> Reported-and-tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> Signed-off-by: Clement Chauplannaz <chauplac@xxxxxxxxx>
>> Signed-off-by: Michal Marek <mmarek@xxxxxxx>
>>
>> *** Bad commit reference: 229455bc02b87f7128f190c4491b4ceffff38648 ***
>> (Linus-tree)
>>
>> To quote [2] and see its EXAMPLE:
>>
>> "If you want to refer to a specific commit, don't just refer to the
>> SHA-1 ID of the commit. Please also include the oneline summary of
>> the commit, to make it easier for reviewers to know what it is about.
>>
>> Example:
>>
>> Commit e21d2170f36602ae2708 ("video: remove unnecessary
>> platform_set_drvdata()") removed the unnecessary
>> platform_set_drvdata(), but left the variable "dev" unused,
>> delete it."
>>
>> That's why the commit-id without the subject-line is no good help.
>> It does not help anyone when you reference a local GIT or linux-kbuild
>> GIT related commit-id.
>>
>> So, can you point me/us to the correct commit with subject, please?!
>> Is this patch even "CC: stable"?
>>
>> Thanks.
>>
>> Regards,
>> - Sedat -
>>
>>
>> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=86eb781889ec31f6421b86ab252ea609d456322d
>> [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n112
>
>
> Hi Sedat,
>
> My apologies for that mistake. The initial commit, as present in Linus tree, is:
> 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's
> POSIX interface
>
> Thus, the commit message for this patch should read:
> scripts/config: fix variable substitution command
>
> Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's
> POSIX interface") accidentally changed the separator between sed `s' command
> and its parameters from ':' to '/'.
>
> Revert this change.
>
> Reported-and-tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Clement Chauplannaz <chauplac@xxxxxxxxx>
> Signed-off-by: Michal Marek <mmarek@xxxxxxx>
>

What means "pending" [1]?
Pending in sense of "we are working on it" or in the sense of
"exists-but-not-published".
I did not found a hint on the offline linux-kbuild ML.
BTW, the GIT repo of Yann is not browsable (which is sh*t for checking
commits quickl, I don't want to be forced to checkout).

- Sedat -

[1] http://marc.info/?l=linux-kbuild&m=137907590807755&w=2
[2] https://www.gitorious.org/linux-kconfig/linux-kconfig/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/